search

graylog-labs / gelf-rb

Ruby GELF library (Graylog Extended Log Format)
https://rubygems.org/gems/gelf
MIT License
153 stars 104 forks source link

Ruby 2.5.0: updated SSLContext interface #76

Open milgner opened 5 years ago

milgner commented 5 years ago

Assigning ctx.ciphers does not work anymore like it used to. We'll need to set min_version and max_version instead.

Simonot commented 5 years ago

Hello,

Any update on that ?

Or should we use gelf 3.0.0 for ruby >= 2.5.0 ?

chriscoester commented 5 years ago

Not sure if this is a separate issue, but I'm getting: SSL_CTX_set_cipher_list: invalid command when trying to use tls. It seems like the cipher string https://github.com/graylog-labs/gelf-rb/blob/eb2d31cdc4b37c316de880122279bcac52a08ba2/lib/gelf/transport/tcp_tls.rb#L91 should be: 

"TLSv1.2:TLSv1.1:TLSv1:!aNULL:!eNULL:!LOW:!3DES:!MD5:!EXP:!PSK:!DSS:!RC4:!SEED:!ECDSA:!ADH:!IDEA:!3DES"

Patching this solves the issue for me and is also in line with how the OpenSSL cli-tool behaves.

matti commented 4 years ago

^-- yep, this is required patch