search

graylog-labs / graylog-plugin-dnsresolver

Message filter plugin to reverse lookup the source field
Apache License 2.0
9 stars 6 forks source link

Support changed Guava SimpleTimeLimiter API #3

Closed lammel closed 6 years ago

lammel commented 6 years ago

During the upgrade to Graylog v2.4.0 we had issues with bringing up the server. The reason was an error DnsResolver caused an error:

2018-01-05T09:00:06.128+01:00 ERROR [CmdLineTool] Guice error (more detail on log level debug): Error injecting constructor, java.lang.IllegalAccessError: tried to access method com.google.common.util.concurrent.SimpleTimeLimiter.<init>(Ljava/util/concurrent/ExecutorService;)V from class org.graylog.plugin.filter.dns.DnsResolverFilter

This pull request changes the SimpleTimeLimiter to use the new Guava API.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

lammel commented 6 years ago

Updated based on feedback and synced handling for version with graylog-plugin-internal-logs plugin.

Should be ready to merge. Tested on our Graylog 2.4 server.

lammel commented 6 years ago

Argh. Should have used the command line ;-) Removed again, maybe some of that stuff should be added to .gitignore

Happy merging.

joschi commented 6 years ago

maybe some of that stuff should be added to .gitignore

FWIW, you can add generic IDE files to your global .gitignore file: https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

joschi commented 6 years ago

@lammel Thanks!