graylog-labs / graylog-plugin-metrics-reporter

Graylog Metrics Reporter Plugins
https://www.graylog.org/
GNU General Public License v3.0
80 stars 18 forks source link

Add mapping rules functionality #14

Closed neumayer closed 6 years ago

neumayer commented 7 years ago

We currently produce 1:1 rules from dropwizard metrics. This leads to things encoded in the metric name that should not be according to prometheus best practices (i.e. things should be labels rather than part of the metric name).

In this commit functionality is added to provide a mapping from metric names to labels, similar to the statsd_exporter approach:

https://github.com/prometheus/statsd_exporter

CLAassistant commented 7 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Robert Neumayer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

neumayer commented 7 years ago

Things I know of for now:

jalogisch commented 6 years ago

@neumayer would you please sign the CLA for all commits - after that is clean we are able to look into this.

Without the CLA sign for all commits I would close this PR in the next week.

jalogisch commented 6 years ago

@neumayer as you did not submitted the CLA for all changes we are not able to merge this PR.

Please re-submit it with a CLA included for all changes.

Thank you