search

graylog-labs / graylog-plugin-slack

Graylog alarm callback for Slack
https://www.graylog.org
Apache License 2.0
117 stars 52 forks source link

Graylog 2.3 compatibility #52

Closed pbr0ck3r closed 6 years ago

pbr0ck3r commented 6 years ago

Graylog 2.3.0 deprecated some of the methods in org.graylog2.plugin.Version.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

joschi commented 6 years ago

@pbr0ck3r Do you have any problems running the latest release of this plugin with Graylog 2.3.0?

While some methods of the Version class have been deprecated, they will still work in Graylog 2.x and only be removed in Graylog 3.0.0.

If we merged this PR, the plugin couldn't be used in Graylog 2.0.x anymore.

pbr0ck3r commented 6 years ago

After downloading and testing with 2.3 it seems everything seems to be working. I do understand the concern of changing MetaData and therefore breaking 2.0. This can be closed.