search

graylog-labs / graylog-plugin-slack

Graylog alarm callback for Slack
https://www.graylog.org
Apache License 2.0
117 stars 52 forks source link

URLs are not URL-encoded breaking the markdown rendering in Mattermost #54

Closed svnk closed 6 years ago

svnk commented 6 years ago

We use the plugin in mattermost and have messages like this:

*New message in Graylog stream [Foo Exceptions]
(https://graylog/streams/58311e2b2ab79c080136c1d9/messages?q=*&rangetype=relative&relative=3600)*:

the star () in q= is seen as ending the italic section leaving the message rendered as

New message in Graylog stream [Foo Exceptions](https://graylog/streams/58311e2b2ab79c080136c1d9/messages?q= &rangetype=relative&relative=3600)*:

(w/o the blank. the github markdown renderer is smarter than the markdown renderer of mattermost.)

If the URL is URL-encoded, this can be avoided.

Aenima4six2 commented 6 years ago

I'll take a look at this.

towolf commented 6 years ago

Actually, with https://github.com/graylog-labs/graylog-plugin-slack/pull/60 in, the asterisk should be gone.

Not that this means, that this Issue is not relevant. But the newest build should work around it.

towolf commented 6 years ago

Ah, scratch that, there are two links in the message, and the second one is still broken.

towolf commented 6 years ago

Please merge PR #63 @Aenima4six2, tested here successfully