graylog-labs / graylog-plugin-slack

Graylog alarm callback for Slack
https://www.graylog.org
Apache License 2.0
117 stars 52 forks source link

Context help in Alert Configuration UI under Custom Message box references old documentation #62

Closed bronius closed 6 years ago

bronius commented 6 years ago

When configuring a new or editing existing Alert Configuration, the help text under the Custom Message refers to an older (1.3) version of Graylog but should refer to 2.3 (and under a different section in docs at that). See: graylog alert link to docs

In: https://github.com/graylog-labs/graylog-plugin-slack/blob/bd1cc8061cdf80b301c5283d16abed1772b96b11/src/main/java/org/graylog2/plugins/slack/configuration/SlackConfigurationRequestFactory.java#L52 the URL: http://docs.graylog.org/en/1.3/pages/streams.html should probably be: http://docs.graylog.org/en/2.3/pages/streams/alerts.html#email-alert-notification or maybe without the named anchor if that's likely to change.

Aenima4six2 commented 6 years ago

Good catch. All fixed in 3.0.1