search

graylog-labs / graylog2-puppet

[DEPRECATED] Puppet module to install and manage a Graylog 1.x system.
https://www.graylog.org/
MIT License
10 stars 28 forks source link

graylog2::server parameter defaults do not work with puppet 2.7 #4

Closed fungusakafungus closed 10 years ago

fungusakafungus commented 10 years ago

Steps to reproduce:

$ cd graylog2-puppet
$ git clone git@github.com:puppetlabs/puppetlabs-stdlib.git stdlib
...
$ ln -s . graylog2
$ PUPPET_VERSION=2.7.25 bundle install
...
$ puppet apply --modulepath=. -e 'class {"graylog2::server": password_secret=>"a000000000000000000000000000000000000000000000000000000000000000", root_password_sha2=>"a000000000000000000000000000000000000000000000000000000000000000"}'
Must pass elasticsearch_config_file to Class[Graylog2::Server::Configure] at /home/ilya/src/graylog2-puppet/graylog2/manifests/server/configure.pp:11 on node ...

This may have been introduced with https://github.com/Graylog2/graylog2-puppet/commit/b6e20f29d40e12964d983277613920f38ba1bf0d and has to do with passing undef as required class params.

The impact of this issue is that all of the following params must be set:

$ grep undef manifests/server/params.pp
  $elasticsearch_config_file = undef
  $elasticsearch_discovery_zen_ping_unicast_hosts = undef
  $elasticsearch_network_bind_host = undef
  $elasticsearch_network_host = undef
  $elasticsearch_network_publish_host = undef
  $http_proxy_uri = undef
  $mongodb_password = undef
  $mongodb_replica_set = undef
  $mongodb_user = undef
  $password_secret = undef
  $root_password_sha2 = undef
  $rules_file = undef
  $transport_email_web_interface_url = undef
bernd commented 10 years ago

Thank you for the report!