search

graylog-labs / syslog4j-graylog2

The syslog4j fork from Graylog2. This is used since 0.10.0. The original code was very "special" and no actions were taken to improve it. This is planned to be replaced completely in future versions.
GNU Lesser General Public License v2.1
32 stars 40 forks source link

Implemented compatibility with frame header. #6

Closed negar7918 closed 8 years ago

negar7918 commented 8 years ago

Implemented compatibility with frame header. Frame header is for instance used by syslog() driver in syslog-ng server and is used to support RFC5424.

negar7918 commented 8 years ago
  1. RFC5424 compatibility in timestamp and message length 2. Introduced a new log method to pass timestamp as argument when calling the log method (this is to be able to see the original timestamp in the syslog)
joschi commented 8 years ago

@negar7918 Thank you very much for your contribution! I have a few questions left and then we're ready to merge.

negar7918 commented 8 years ago

ok I will be answering your questions :)

On Wed, Feb 17, 2016 at 3:23 PM, Jochen Schalanda notifications@github.com wrote:

@negar7918 https://github.com/negar7918 Thank you very much for your contribution! I have a few questions left and then we're ready to merge.

— Reply to this email directly or view it on GitHub https://github.com/Graylog2/syslog4j-graylog2/pull/6#issuecomment-185226601 .

negar7918 commented 8 years ago

I am a bit unhappy about the whole existing design .. I would have a seperate place for RFC5424 compatibility but seemed easiest to put those stuff (timestamp and message legnth) under structured data classes even though it is not exactly relevant ..

On Wed, Feb 17, 2016 at 3:25 PM, Negar Safinia negar7918@gmail.com wrote:

ok I will be answering your questions :)

On Wed, Feb 17, 2016 at 3:23 PM, Jochen Schalanda < notifications@github.com> wrote:

@negar7918 https://github.com/negar7918 Thank you very much for your contribution! I have a few questions left and then we're ready to merge.

— Reply to this email directly or view it on GitHub https://github.com/Graylog2/syslog4j-graylog2/pull/6#issuecomment-185226601 .

joschi commented 8 years ago

Thanks!

negar7918 commented 8 years ago

Awesome!

On Thu, Feb 18, 2016 at 2:32 PM, Jochen Schalanda notifications@github.com wrote:

Merged #6 https://github.com/Graylog2/syslog4j-graylog2/pull/6.

— Reply to this email directly or view it on GitHub https://github.com/Graylog2/syslog4j-graylog2/pull/6#event-555082622.