search

graypegg / chromatism

:rainbow: A simple set of utility functions for colours.
1.78k stars 37 forks source link

Eliminate HSV->RGB or HSL->RGB conversion #25

Closed TehShrike closed 7 years ago

TehShrike commented 7 years ago

HSV and HSL are very similar, and those conversions take a lot of code, so it's better not to keep both versions around.

Context: https://github.com/toish/chromatism/pull/24

When I tried removing either of the conversions, the output values changed enough that the tests wouldn't pass.

This implies that the conversions might be lossier than they should be, or one of them is less accurate than it should be.

graypegg commented 7 years ago

Fixed in #26