Condensing hsl and hsv conversions

graypegg / chromatism

:rainbow: A simple set of utility functions for colours.

1.78k stars 37 forks source link

Condensing hsl and hsv conversions #26

Closed graypegg closed 7 years ago

graypegg commented 7 years ago

This PR removes the HSV=>RGB conversion, because it's pretty much a duplicate of HSL=>RGB. Also using a desaturated version of test colour for shade as well. The one we were using had a 'v' value of 100, so it couldn't express a brighter version.

TehShrike commented 7 years ago

aw, no chance for peer review?

graypegg commented 7 years ago

Oops, sorry! Was thinking because it merged into refactor I'd just merge it in, bad choice on my part! If you don't mind looking it over quick, will revert it if you find anything!