search

graypegg / chromatism

:rainbow: A simple set of utility functions for colours.
1.78k stars 37 forks source link

Need to include CJS bundle in repo so this package can continue to work in CDNjs #27

Closed graypegg closed 7 years ago

graypegg commented 7 years ago

Chromatism got included in CDNjs, and I don't wanna break the package when used thru it in the browser! Thinking we should un-gitignore /dist?

TehShrike commented 7 years ago

CDNjs uses Github instead of npm?

graypegg commented 7 years ago

It won't run a build task AFAIK, so I'm thinking we need to have a browser-compatible build already in the package

TehShrike commented 7 years ago

It doesn't look like CDNjs would require anything in this repo - it would only require that we open pull requests to their repo to add the built/minified file.

I like unpkg because it doesn't require me to do anything besides push to npm ;-) https://unpkg.com/chromatism

graypegg commented 7 years ago

PR #29 adds the /dist directory to the NPM packages, which contains a UMD module