search

graypegg / chromatism

:rainbow: A simple set of utility functions for colours.
1.78k stars 37 forks source link

Convert function declarations to arrow functions #36

Closed kale-io closed 6 years ago

graypegg commented 6 years ago

Wow thank you! Not sure what's going on with hound CI here, will have to look into that!

I will be able to take a close look into this tomorrow and hopefully merge it in, thanks for catching these!

iondrimba commented 6 years ago

@toish maybe a missing .hound.yml with an .eslintrc config https://houndci.com/configuration#eslint

kale-io commented 6 years ago

Hey @toish any update on this? Do you need any help?

kale-io commented 6 years ago

@toish do you have any update on this? Thanks (:

graypegg commented 6 years ago

Hi @kale-io, sorry, work has me seriously drained and I haven't had the time to focus on this as much as I'd like to. My best assumption is that I just need to add esversion: 6 to a hound.yml file. Would love some help, as I actually don't remember setting up HoundCI on this project, had some help from a friend a little while ago refactoring this project, and he may have added this project to a HoundCI account.

TehShrike commented 6 years ago

I'd never heard of HoundCI before this issue :-x

kale-io commented 6 years ago

Apparently, HoundCI uses JSHint by default: https://houndci.com/configuration#javascript

So, in order to change the behavior, you need to specify the ES version in a .jshintrc file:

{
  "esversion": 6
}

Then, you need to reference this config file in your .hound.yml file:

jshint:
  config_file: .jshintrc

... or, disable style checking:

jshint:
  enabled: false
kale-io commented 6 years ago

Opened a new pull request on the latest master. hound-ci is still hounding us there 😄. #37 should help.