graysky2 / profile-sync-daemon

Symlinks and syncs browser profile dirs to RAM thus reducing HDD/SDD calls and speeding-up browsers.
https://wiki.archlinux.org/index.php/Profile-sync-daemon
Other
903 stars 86 forks source link

psd fails if /sbin or /usr/sbin is not in PATH #217

Closed JanLuca closed 6 years ago

JanLuca commented 6 years ago

In profile-sync-daemon there are multiple calls to modinfo. This calls fails if /sbin or /usr/sbin is not in PATH. Could you use the absolute path to the tools used so they do not depend on the environment?

Thank you in advance, Jan

graysky2 commented 6 years ago

The script depends on many dependencies being in the path, for example, rsync, awk, modinfo, etc. I am trying to imagine a setup in which one would not was those paths in the global $PATH...

behrmann commented 6 years ago

The issue is rather, that the calls to modinfo fail if /usr is not merged. On arch modinfo is situated in /usr/bin and not in /usr/sbin, where it is in Debian, and /usr/sbin is not necessarily in the $PATH for historical reasons.

Could the hard dependency on modinfo maybe avoided if the overlayfs feature is not used?

behrmann commented 6 years ago

Having debuged the problem a bit further the problem is a bit less clear. We will report back with more info.

graysky2 commented 6 years ago

The issue is rather, that the calls to modinfo fail if /usr is not merged. On arch modinfo is situated in /usr/bin and not in /usr/sbin, where it is in Debian, and /usr/sbin is not necessarily in the $PATH for historical reasons.

I don't understand that.... if you put modinfo in /foo/bar and if /foo/bar is in your path, it works. If not, it doesn't work. Your global vars don't seem to be right for whatever reason.

eMPee584 commented 4 years ago

On debian modinfo is in /sbin, which is not in a normal user's path.