Docs should warn about quit browser before start/stop daemon ?

graysky2 / profile-sync-daemon

Symlinks and syncs browser profile dirs to RAM thus reducing HDD/SDD calls and speeding-up browsers.

https://wiki.archlinux.org/index.php/Profile-sync-daemon

Other

899 stars 84 forks source link

Docs should warn about quit browser before start/stop daemon ? #305

Open BillDietrich opened 2 years ago

BillDietrich commented 2 years ago

I haven't tested this, but I think bad things could happen if PSD is started or stopped while an applicable browser is running. Shouldn't there be a warning in the docs and Wiki saying something like "Quit out of all browsers before starting or stopping the PSD daemon." ? Otherwise the browser could be using a profile and the daemon suddenly tries to move it to somewhere else.

graysky2 commented 2 years ago

https://github.com/graysky2/profile-sync-daemon/blob/master/common/profile-sync-daemon.in#L375

BillDietrich commented 2 years ago

Okay, thanks. So the code looks like:

if starting PSD and a browser is running, refuse to start PSD.
if stopping PSD and a browser is running, kill the browser.

I guess the 2nd case must do a kill instead of "refuse to stop PSD" because we could be in the middle of shutting down the system ?