graysky2 / profile-sync-daemon

Symlinks and syncs browser profile dirs to RAM thus reducing HDD/SDD calls and speeding-up browsers.
https://wiki.archlinux.org/index.php/Profile-sync-daemon
Other
913 stars 88 forks source link

Feature request: Zen Browser support #378

Closed bkuri closed 1 month ago

bkuri commented 2 months ago

Should be pretty straightforward since it's firefox-based:

Thanks in advance!

bkuri commented 2 months ago

I made an AUR package to implement this here: https://aur.archlinux.org/packages/profile-sync-daemon-zen

FYI a zen-browser profile is placed in /usr/share/psd/browsers and looks like this:

if [[ -d "$HOME"/.zen ]]; then
    index=0
    PSNAME="zen-browser"
    while read -r profileItem; do
        if [[ $(echo "$profileItem" | cut -c1) = "/" ]]; then
            # path is not relative
            DIRArr[$index]="$profileItem"
        else
            # we need to append the default path to give a
            # fully qualified path
            DIRArr[$index]="$HOME/.zen/$profileItem"
        fi
        (( index=index+1 ))
    done < <(grep '[Pp]'ath= "$HOME"/.zen/profiles.ini | sed 's/[Pp]ath=//')
fi

check_suffix=1
itsHanibee commented 1 month ago

Support for it already exists, I added it on August and it's been there since https://github.com/graysky2/profile-sync-daemon/commit/fb87ff8c8d997d8b79b52c284feb6434d06eb0fe

bkuri commented 1 month ago

@itsHanibee good to know. I think I did this because I couldn't find Zen Browser in the README.

Thanks!

itsHanibee commented 1 month ago

@itsHanibee good to know. I think I did this because I couldn't find Zen Browser in the README.

Thanks!

Have a point here, adding browsers available via contrib/ needs to be documented somewhere.

README or the Arch Wiki would work.

@graysky2 thoughts?

ch4og commented 1 month ago

Created PR https://github.com/graysky2/profile-sync-daemon/pull/380 that adds Zen Browser to README

itsHanibee commented 1 month ago

Created PR #380 that adds Zen Browser to README

Nah, gotta be more specific I feel like. Community supported programs aren't gonna work ootb, people are gonna read that Zen is supported and will just use psd like normal and leave Issues that it doesn't report properly.

More info is needed, maybe a section informing that there's "semi-official" support for certain browsers and the steps to get them set up properly.

Another thing is that if we are adding Zen to the README, it's ideal to add all the other community browsers too just for completion's sake.