search

graysky2 / profile-sync-daemon

Symlinks and syncs browser profile dirs to RAM thus reducing HDD/SDD calls and speeding-up browsers.
https://wiki.archlinux.org/index.php/Profile-sync-daemon
Other
910 stars 88 forks source link

merge Makefiles #39

Closed hasufell closed 11 years ago

hasufell commented 11 years ago

as per https://github.com/graysky2/profile-sync-daemon/pull/38

about the configure proposal: writing one yourself is a huge(!) pain in the ass. See scummvm for an example. The other way would be to use autotools, but that is definitely oversized for a project like this. A simple Makefile with distro-targets, especially for the init-parts would be enough.

graysky2 commented 11 years ago

OK. So no configure script and just a single Makefile. In principal, I think you are suggesting one with following construct?

main section:
common files to all distros

distro-1
specific files

distro-2
specific files

distro-3
specific files

Functionally, would users simply do the following?

make distroxxx
make install

Again, if you are willing to send a pull request with a draft Makefile, I would be willing to fill in the details.

graysky2 commented 11 years ago

Please have a look at the unstable branch for a proposed solution based on simplicity. https://github.com/graysky2/profile-sync-daemon/commit/7450faeb42a1dc0c3a016446a7612bc4f5017814

1) Moved the individual Makefile.xxx to ./config 2) A simple configure script will select the correct one for supported distros

Feedback is appreciated.

hasufell commented 11 years ago

As explained before I'd prefer no configure script, because that is just hiding the unnecessary complexity behind that configure file.

Let's see what's common between all Makefiles:

Then we need rules for different init systems:

The installation guide should then explain that you need to do: make install

the init-target would then depend on another default target that installs the stuff that is common between all Makefiles as explained above.

graysky2 commented 11 years ago

I agree with your analysis, but I lack the Makefile skills to add the logic on my own and you have already expressed a lack of available time, so I won't ask you again :) If you have some bandwidth in the near future, I am interested in the more elegant solution you propose.

hasufell commented 11 years ago

see #40