search

grayver / mi-vigem

ViGEm adapter for Xiaomi Gamepad
MIT License
69 stars 23 forks source link

Sometimes the vibration does not stop. #2

Closed zhangbo8418 closed 3 years ago

zhangbo8418 commented 4 years ago

Just like mi-360,sometimes the vibration does not stop.

grayver commented 4 years ago

Hmm.. actually I'm experiencing the same in Super Lucky's Tale. I thought this is somehow connected with the game itself, but now I suspect that ViGEm is the problem. If you are experiencing same problem with mi-360 (which also uses ViGEm) then I'm almost sure that problem is somewhere in ViGEm. I'll try to communicate with ViGEm developers about this issue.

P.S. what game this issue is reproducible with?

zhangbo8418 commented 4 years ago

The same in all games.

zhangbo8418 commented 4 years ago

Hmm.. actually I'm experiencing the same in Super Lucky's Tale. I thought this is somehow connected with the game itself, but now I suspect that ViGEm is the problem. If you are experiencing same problem with mi-360 (which also uses ViGEm) then I'm almost sure that problem is somewhere in ViGEm. I'll try to communicate with ViGEm developers about this issue.

P.S. what game this issue is reproducible with?

ViGEm has a new version, can you help compile it?

grayver commented 4 years ago

Could you try version 1.0.1 I've just released?

zhangbo8418 commented 4 years ago

Could you try version 1.0.1 I've just released?

No, the vibration will not stop. How to install ViGEmBus-1.17.258.0?

grayver commented 4 years ago

No, the vibration will not stop. How to install ViGEmBus-1.17.258.0?

It seems to be they haven't published new installer yet. So you need to compile binaries from source code (and they will be unsigned, BTW).

But I think it wouldn't fix that problem. I talked to them yesterday and they said that problem either in client library, either in game itself. They confirmed, that problem existed in old client library which I used in release 1.0.0. Release 1.0.1 uses latest ViGEm client library.

I'm planning to add forced limitation for vibration time and this should help in that case.

zhangbo8418 commented 4 years ago

As you said, there is indeed no solution. I compiled their new driver, but the problem remains（ I disabled signature detection.）. https://github.com/irungentoo/Xiaomi_gamepad No problem, but occasionally it will disconnect, and then you need to restart the program.So it must be ViGEm's problem.

grayver commented 4 years ago

I've added limitation for constant long vibration in release 1.1.0 (2 sec). Can you try it out?

zhangbo8418 commented 4 years ago

Okay, it can stop vibration.