graywolf336 / CasinoSlots

Animated, customizable, block-based slot machines, including audio, inside of Minecraft!
http://dev.bukkit.org/server-mods/casino-slots/
GNU General Public License v2.0
23 stars 24 forks source link

Issues with [player] and broadcast action #46

Closed EmpathyHeals closed 10 years ago

EmpathyHeals commented 10 years ago

I am encountering two problems: 1) It will not broadcast the player name when I type [player] in the config but the same broadcast does shout the [type] and the [cost] out just fine; so in essence there is a broadcast that states [player] played on this machine, spent this much, and won, but the player name doesn't actually show up. 2) Each payout only performs one action, so if the action is to broadcast then the item does not give; I figured I would work with the [player] limitation by simply shouting Payout! Machine Itemslot rewarded a spin of $500! As I was testing this though I realized it was shouting on win but I was not receiving the items. So, in the end I went back and #'s buy all the broadcasts and here I am with a ticket. Here is how I have my config file now: casino1 I found the documentation here http://dev.bukkit.org/bukkit-plugins/casino-slots/pages/info/actions/ for how to type the broadcast and variables but there is no example to use it in context; where do you type it - under the other action, under each win? What format do you type in? Do you put quotes, %'s? It would help to see a config file for how you intend a player to write this so it will broadcast all those variables to the server so then I can just take a variable out or re-arrange it, but I could see how/where I am supposed to place the code in the config file.

Thanks!!! Empathy

graywolf336 commented 10 years ago

Just pushed a fix that will fix this issue, realized what was wrong but fixed it in a cleaner method.

The other issue about not being able to do two actions, please create a separate ticket for that so we can keep them separated. Thanks

EmpathyHeals commented 10 years ago

Hi, I don't really undersatnd; by "pushing" a fix do you mean you have a new version out of the plugin out and I need to re-download and re-install?

Also, what exactly was fixed, the [player] name not showing? Will just [player] work to show player name out like [type] shows up the machine type? You said to put in a new ticket about the plugin not being able to do two actions but they are not really separate issues. If you files the [player] and it shouts the player name but does not give out the items then the broadcast is not working and so the whole line with player and type and cost needs to be left out (or else everyone hears the shout but the player does not get their item). I can do a separate ticket if you want but I don't think the first is really a fix without the second, which seems the priority.

Finally, is there a way to alter the rate of payout so the house has a certain % advantage? Say that I want to sell them to players, I want players to be able to profit from people playing the slots over time and the owners of casinos to compete over who has the best payout. If that is not something this plugin does let me know.

Thank you! Emp

Date: Thu, 20 Mar 2014 10:03:26 -0700 From: notifications@github.com To: CasinoSlots@noreply.github.com CC: Subject: Re: [CasinoSlots] Issues with [player] and broadcast action (#46)

Just pushed a fix that will fix this issue, realized what was wrong but fixed it in a cleaner method.

The other issue about not being able to do two actions, please create a separate ticket for that so we can keep them separated. Thanks

— Reply to this email directly or view it on GitHub.

graywolf336 commented 10 years ago

The code to fix the problem has been pushed to this git repository. The version which contains the fix has been built but has not been uploaded to Bukkit Dev for people to download.

Yes, [player] not showing is what was fixed.

I requested a new ticket to be made for the plugin not doing two actions at once.

No there isn't a way to do that, that's not how the plugin is coded. Think of it like putting marbles into a bag and then randomly putting your hand in and taking it out, if it was the same type as the last one you took out you have to put it back and get another one. It is random like that.