search

graze / dal

Data Access Layer
MIT License
8 stars 0 forks source link

Ensure EloquentOrm\EntityPersister returns null if no record is found. #26

Closed wpillar closed 9 years ago

wpillar commented 9 years ago

Without this you get that 'value entity "" is not null' thing. We had to do the same fix for PropertyTableMapAdapter way back when.

sjparkinson commented 9 years ago

It works, but I'm not the biggest fan of merging a bug fix that has no tests. Verifying by having to modify vendor is :cry:.

It'd be good to see issue #23 looked into sometime, getting the framework setup at least so it's not a pain to write tests for PR's like this.