Added JSON-RPC 2.0 error data to response

graze / guzzle-jsonrpc

JSON-RPC 2.0 client for Guzzle

https://packagist.org/packages/graze/guzzle-jsonrpc

MIT License

93 stars 61 forks source link

Added JSON-RPC 2.0 error data to response #26

Closed TSchuermans closed 8 years ago

TSchuermans commented 8 years ago

As defined in: http://www.jsonrpc.org/specification#error_object

adlawson commented 8 years ago

Hey @TSchuermans, thanks for your changes!

Would you be able to update the tests too? I think it's just a couple of unit tests in ResponseTest.php and assertions to the responses in the functional tests that's needed.

I'm not sure what's happened to the StyleCI stuff but @sjparkinson might know what's up.

TSchuermans commented 8 years ago

Should be updated @adlawson

sjparkinson commented 8 years ago

Ah needed to remove the StyleCI required check from the repos settings.

adlawson commented 8 years ago

Looks good to me. Thanks again @TSchuermans (and thanks @sjparkinson for sorting StyleCI) :rocket: :tada: