graze / guzzle-jsonrpc

JSON-RPC 2.0 client for Guzzle
https://packagist.org/packages/graze/guzzle-jsonrpc
MIT License
93 stars 61 forks source link

modernise the development environment a bit #30

Closed h-bragg closed 7 years ago

h-bragg commented 7 years ago

List of all changes

  1. Deleted Vagrantfile
  2. Updated .travis.yml to support more versions
  3. moved all commands to docker
  4. added docker-compose.yml file with: test/node/composer services
  5. use graze/composer to run composer
  6. use graze/php-alpine to run tests
  7. use node:8 to run the node test server
  8. Fixed the markdown in README.md
  9. Removed the .lock files from the .gitignore file and committed them
  10. Added phpcs linting based on graze/standards
  11. Added scruitinzer badges to README
  12. Fixed items flagged by phpcs
  13. Updated the Makefile with help, lint, test-coverage targets
  14. Fixed various scruitinzer issues
  15. Fixed some tests that were not being run correctly (namely BatchFunctionalTest)
biggianteye commented 7 years ago

A make help target would be nice.

h-bragg commented 7 years ago

@biggianteye went and did some other bits that spawned from a re-look.

namely committing .lock files because of https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/

biggianteye commented 7 years ago

The gitignore file which ignored composer.lock is from the skeleton project. Is it worth updating that as well?

h-bragg commented 7 years ago

Yeah, we should probably update the skeleton project

biggianteye commented 7 years ago

Scrutinizer is failing because of doctrine/instantiator. Sigh.

h-bragg commented 7 years ago

I am hoping that disabling the tests in scrutiniser will help... lets see...

biggianteye commented 7 years ago

I'll review the the guzzle 3/4/5 PRs once this one is merged.