search

graze / queue

:postbox: Flexible abstraction for working with queues in PHP.
MIT License
49 stars 10 forks source link

Add the mockery test listener to the phpunit config #11

Closed sjparkinson closed 9 years ago

sjparkinson commented 9 years ago

We were having some issues with Mockery expectation validation in #9, turns out it was because we were not calling Mockery::close().

This PR adds the bundled mockery test listener to the phpunit config.

See http://docs.mockery.io/en/latest/reference/phpunit_integration.html.

There were three errors that resulted in adding the listener, which these changes "resolve".

I couldn't work out if Jake intended there to be three calls to isValid in all the handlers, hence the PR to get a sanity check :confused:.

h-bragg commented 9 years ago

That makes sense.

Looks sensible (with isValid) apart from lots of repeated code. At least its clear whats going on.

:+1:

sjparkinson commented 9 years ago

Thanks!