search

graze / skeleton-project

☠ A skeleton repository for Graze open source projects.
http://graze.github.io/skeleton-project/
MIT License
3 stars 2 forks source link

Set PHP error_reporting to E_ALL #16

Closed john-n-smith closed 7 years ago

john-n-smith commented 7 years ago

@h-bragg, are you down with this change? Would it be a better idea add a php.ini file to the repo and mount it?

h-bragg commented 7 years ago

I would probably say this is the responsibility of each repository to define their php configuration. Willing to change my mind though.

john-n-smith commented 7 years ago

@h-bragg, it seems good practice to me to write code that does not create any errors in PHP. Maybe this is something we could add to graze/standards, before enforcing here.

h-bragg commented 7 years ago

Yeah, probably.

Maybe we could do it differently:

  1. Include the base php.ini file in this repository
  2. Include a php.ini file to be added to the /etc/php/conf.d/ directory with just this setting in it. Then this file can be modified by each repository and its there...

I like the second option (i think stats does this now w/ dev and production)

john-n-smith commented 7 years ago

That was my suggestion in the PR description 😄 I'll do that and suggest it as a standard.