Feature/pla 370 aws naming conventions - Githubissues

graze / standards

⚖ The coding standards of the graze tech team.

https://graze.github.io/standards/

MIT License

6 stars 2 forks source link

Feature/pla 370 aws naming conventions #31

Closed sldsmkd closed 7 years ago

schettle commented 7 years ago

Could you please add a meaningful description? Our PRs normally prompt you to fill out a template with the headings

Summary
Notable Changes
QA

h-bragg commented 7 years ago

@sldsmkd mind having a look (i added dev,stage,test and live). Are these the only places we use these?

h-bragg commented 7 years ago

@biggianteye mind having a look a the markdown to see if it make sense? The invalidness was bothering me.

h-bragg commented 7 years ago

@biggianteye updated. My changes are based on: https://github.com/DavidAnson/markdownlint

h-bragg commented 7 years ago

@biggianteye is there anything left to change?

biggianteye commented 7 years ago

@h-bragg Happy with the changes, though the travis builds are failing.

h-bragg commented 7 years ago

thats because travis is only setup for another branch currently (although just merged). Rebasing so it runs through travis