search

grblHAL / Plugin_keypad

grblHAL keypad plugin
Other
7 stars 6 forks source link

Changed cycle start and feed hold I2C key characters #6

Open andrewmarles opened 1 year ago

andrewmarles commented 1 year ago

to modern from legacy due to conflict with macro6 keycode.

As I may have to table this work for some time, I wanted to pass this upstream.

terjeio commented 1 year ago

This is a breaking change, would it be better to assign new trigger characters for the macros? Still breaking but likely less code out in the wild using the macros plugin? Top bit set characters from 160 up is IMO the safest.

andrewmarles commented 1 year ago

Ok, that will work. Very little macro code out there as far as I know :)