search

grblHAL / Plugins_spindle

grblHAL plugins for spindle control
Other
9 stars 13 forks source link

modbus_rtu receives zero length packet #26

Closed Nick507 closed 8 months ago

Nick507 commented 8 months ago

image Shouldn't rx_len be used as loop counter? Otherwise received packed has zero rx_length.

UPD: I see, that rx_len is used below, in CRC check. Ok, then we can't use it in loop. But it is very confusing to get packet in receive callback with zero length. Maybe restore packet->msg.rx_length = rx_len after CRC check?

terjeio commented 8 months ago

Maybe restore packet->msg.rx_length = rx_len after CRC check?

Will add in next commit.