search

grblHAL / Plugins_spindle

grblHAL plugins for spindle control
Other
9 stars 13 forks source link

Fixes for GetMaxRPM issues #4

Closed dresco closed 3 years ago

dresco commented 3 years ago

The spindle plugin would always alarm on startup, as requesting incorrect register number for the max RPM value.

Also hooking into driver reset, else value would never be retrieved if VFD was not responsive during startup.

See discussion -- https://github.com/grblHAL/Plugins_spindle/issues/2#issuecomment-953154600

dresco commented 3 years ago

Meant to say - something I noticed when testing. The very first soft reset after startup still has the sys.cold_start flag set..?

terjeio commented 3 years ago

Seems I clicked the wrong button, my comment was lost...

The very first soft reset after startup still has the sys.cold_start flag set..?

Good catch, I'll reset it in the main protocol loop after all the startup tests has been completed.