search

grblHAL / RP2040

grblHAL driver for RP2040 (Pi Pico)
Other
103 stars 44 forks source link

Minor issue with PROBE_ENABLE==0 #83

Closed wiersmapa closed 1 week ago

wiersmapa commented 4 months ago

I disabled the optional probe in a custom my_machine.h (#define PROBE_ENABLE 0 on line 84). The build failed as It exposes an undeclared probeConfigure() on line 1994 of driver.c. Definition of probeConfigure() (line 1240) is only done if PROBE_PIN is declared (e.g. generic_map line 106) which is dependent on PROBE_ENABLE. Enabling the (unused) probe allowed the build to work. Not sure if enabling the probe (on an unused input pin) would cause other issues.

terjeio commented 4 months ago

Which driver? RP2040?

wiersmapa commented 4 months ago

Sorry, should have mentioned. Was indeed the RP2040.

On Fri, Mar 1, 2024 at 11:43 AM Terje Io @.***> wrote:

Which driver? RP2040?

— Reply to this email directly, view it on GitHub https://github.com/grblHAL/RP2040/issues/83, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDPHML4YP4TUZM45ZA5EZTDYWDK7VAVCNFSM6AAAAABECITX2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZTHAYDSOBXHA . You are receiving this because you authored the thread.Message ID: @.***>