search

grblHAL / core

grblHAL core code and master Wiki
Other
320 stars 84 forks source link

PlatformIO compiling conflict with "limit.h" #184

Closed dresco closed 2 years ago

dresco commented 2 years ago

Hi Terje, would you consider a pull request to rename the grbl limit.c & limit.h files?

Building with networking support exposes this same problem that the Grbl_Esp32 folks faced here, and fixed here.

I see this on my H7 port, am assuming it would be the same for F7. I've fudged around it for now in my platformio.ini

terjeio commented 2 years ago

would you consider a pull request to rename the grbl limit.c & limit.h files

I do not think so as you will have to fix all code referencing the .h file, so better I do it. I have a HAL function signature change I want to implement as well - I can do this at the same time as I work my way through all the drivers.

I'll remame limits.h and limits.c_ to _machinelimits.h and _machinelimits.c since I find _grbllimits to be somewhat ambiguous...

terjeio commented 2 years ago

Done. See changelog.md for signature change++.

dresco commented 2 years ago

Done. See changelog.md for signature change++.

Thanks!