search

grblHAL / core

grblHAL core code and master Wiki
Other
326 stars 85 forks source link

cmake includes plugins by default #382

Closed wiersmapa closed 11 months ago

wiersmapa commented 11 months ago

Tried to build RP2040 from the git repository and ran into errors (for example in 'unused' trinomatic plugin.) The CMakeLists.txt file has if(AddMyPlugin) with the list of plugins and and an else() which lists them all again. I removed the unused plugins from that else() list and it compiled with no errors.

terjeio commented 11 months ago

Which errors? I do not get any.

wiersmapa commented 11 months ago

I pulled a new copy and this time it compiled without errors. I remember a number of errors related to the TRINOMATIC variable declarations (the stream variables in tmc_uart.c) which made me think it was related to the plugins. Not sure what was different before. Thanks, Paul

On Mon, Oct 23, 2023 at 7:51 PM Terje Io @.***> wrote:

Which errors? I do not get any.

— Reply to this email directly, view it on GitHub https://github.com/grblHAL/core/issues/382#issuecomment-1776416816, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDPHML4NA6NALHNVX37NINTYA4UK5AVCNFSM6AAAAAA6MOVWLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWGQYTMOBRGY . You are receiving this because you authored the thread.Message ID: @.***>

terjeio commented 11 months ago

Perhaps a bug in the previous version? I stumble across some now and then, mostly minor and annoying ones. Anyway, thanks for reporting.