search

grblHAL / iMXRT1062

grblHAL driver for NXP iMXRT1062 (Teensy 4.x)
Other
51 stars 39 forks source link

Fix Aux pin init to fix single block issue. #88

Closed JasonTitcomb closed 1 week ago

JasonTitcomb commented 3 weeks ago

I found this code in the STM32F7xx driver so I added this code to the driver.c My test on the physical machine was successful.

if AUX_CONTROLS_SCAN

signals = aux_ctrl_scan_status(signals);

endif

Hopefully I have done this pull request properly as it's my first time creating one.

terjeio commented 2 weeks ago

The pull request is fine for driver.c but should not include the other two files. Can you update it to only contain driver.c changes?

JasonTitcomb commented 1 week ago

I don't see how to do that. Maybe I just close the pull request and you can make the small change?

JasonTitcomb commented 1 week ago

Attempted to restore the two other file and I think it was a fail so I will close the pull request. You can make the small change directly. I should learn git better.

terjeio commented 1 week ago

It was not a fail...