Closed wenz closed 4 months ago
@HackedByChinese could you pls merge this one?
I'm nervous the default behavior for filterEvent is a kludgy mess when it comes to dealing with the user moving the mouse, and I fear user agent detection can make it worse. This needs to be greatly simplified because it's caused other problems in the past. However, I've kind of lost track of all the original bugs that lead to this code :(
Yeah but take a Look into his branch its just a line of Code. I tried it in my current project and it worked like a charm. Would be very happy to have this merge. But could you elaborate further why this would be a bad idea? Maybe i didnt had these edge cases.
@all having this problem while the Pull Request isn't merged consider using the pointermove event which is supported in IE11 and triggers the reset. Therefore you need to create your own DocumentIntruptsources Object and register all events as seen below. This should anyway be the way to go instead of using DEFAULT interuptsources (imo). Code could look like this
const interuptsources = new DocumentInterruptSource("click keydown mousemove pointermove");
this.idle.setInterrupts([interuptsources]);
adding pointermove doesn't work for me. Having issues with mouse move in Chrome: the timer of the timeout warning stops, but the warning stays. When this expected to be checked in?
Tested today with IE11 in a VM; it detects the click and keydown to stop the idle warning. But it does not detect mouse movement, I still get the idle warning if I only move the mouse and do not click or press keys.
Fixes bug #34 by specifically excluding Internet Explorer
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here) https://github.com/HackedByChinese/ng2-idle/issues/34
What is the new behavior? Works in IE11
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: