Closed sliekens closed 6 years ago
For loops over find output are fragile. Use find -exec or a while read loop.
Resolves #81
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
[ ] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [x] Build related changes [ ] CI related changes [ ] Other... Please describe:
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
for d in (find ...) do ...
find -exec ...
process.env.MODE
process.env.npm_config_mode
MODE
npm run build:umd --mode=ugly
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes [x] No
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: https://github.com/koalaman/shellcheck/wiki/SC2044
Coverage remained the same at 99.364% when pulling 47532ba61d69855b34774384b9812d1e9c1cb4f6 on StevenLiekens:bugfix/use-find-exec into 7af83e08335f1f733f4ba14ba054dc2309962627 on HackedByChinese:master.
For loops over find output are fragile. Use find -exec or a while read loop.
Resolves #81
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
81
What is the new behavior?
for d in (find ...) do ...
has been replaced byfind -exec ...
process.env.MODE
has been replacedprocess.env.npm_config_mode
MODE
as an argument:npm run build:umd --mode=ugly
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: https://github.com/koalaman/shellcheck/wiki/SC2044