Closed sliekens closed 6 years ago
Coverage decreased (-0.01%) to 99.353%
That's interesting because if you look at the report, the coverage of each file stayed the same or rose.
Apparently the coverage decreased because I refactored EventTargetInterruptSource to require less code to make the tests pass, causing the relative percentage of untested code to increase. This is why I always hated math.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
In EventTargetInterruptSource:
filterEvent()
runs afterthrottleTime()
eventSrc
is an array ofArray<Observable>
but you should useObservable.merge()
instead of doing all that housekeeping yourselfWhat is the new behavior?
filterEvent()
runs beforethrottleTime()
so that filtered events don't reset the throttle timereventSrc
is now a merged ObservableeventSubscription
is a single Subscription that subscribes or unsubscribes all events at onceDoes this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: I had to fix the formatting a little bit. Someone isn't using EditorConfig.