Fixes for jq, path independence, additional metrics

[nethershaw]

I've made a few changes in my own fork that I think may be helpful. If the maintainers would like me to refactor the proposed commits differently, I'd be happy to rework this on another branch.

The following changelog applies only to the getinfo/ tree of the repository:

• Wherever the path to the .GridcoinResearch/ directory is required, ${GRCPATH} is set using getent passwd gridcoin and automatically set to the correct absolute path based on the user's actual home folder.
• Some whitespace cleanup and string safety quotations.
• Several additional wallet metrics (magnitude, RSA values, lifetime totals, superblock age, DPoR weight, etc.)
• Improved the systemd service installer to be more idempotent. It will no longer:
  • try to add a crontab entry for freegeoip if one already exists
  • create a new tarball for the freegeoip distfiles for each installation (it will overwrite any existing one instead)
  • chmod +x the netdata/charts.d/ script (it doesn't need to be, and shouldn't be, executable; it's included in memory when netdata sources it)
• jq no longer chokes on:
  • IPv6 addresses when passing them to freegeoip
  • null country codes (really)
• A few conservative cosmetic tweaks (e.g., easier-to-read systemd unit descriptions for the timers when they appear in your journal every 5sec)

[grctest]

+CHART Gridcoin.rsa '' "Gridcoin research savings account" "GRC" RSA gridcoin.rsa line $((load_priority + 1)) $gridcoin_update_every
+DIMENSION paid_daily 'Paid daily' absolute 1 1
+DIMENSION paid_14days 'Paid 14 days' absolute 1 1
+DIMENSION exp_daily 'Expected daily' absolute 1 1
+DIMENSION exp_14days 'Expected 14 days' absolute 1 1
+CHART Gridcoin.fulfillment '' "Gridcoin fulfillment" "percent" Fulfillment gridcoin.fulfillment line $((load_priority + 1)) $gridcoin_update_every
+DIMENSION fulfillment '% Fulfilled' absolute 1 1

Quick sanity check on my part - is the RSA and the above settings still relevant to the latest client version?

[grctest]

+GRCAPP="$(which gridcoind)"

Should this not be 'which gridcoinresearchd'?

[grctest]

Aside from the above two questions, the PR looks good to me. Thoughts, @Foggyx420 ?

[nethershaw]

@grctest To your first question -- yes, the settings you quoted are still available from the RPC of the latest release client, 3.5.9.1. For the second -- yes, it probably should be which gridcoingresearchd ... I've seen inconsistent references to a gridcoind in some dialogs and documentation strings, so I wasn't sure what the canonical name of the binary ought to be.

I'll change my conventions elsewhere so that the binary's name is whatever upstream decides it should be.

[iFoggz]

guess I haven't updated anyone in awhile:

grcpath is now set in a config on my test repo and the config is called for the path information, etc

grcpath is customly setup during the execution of the one line installer. . I opted to not use getent I believe as I didn't wish to allow any kind of compiler access or root access from normal user accounts for security reasons and a config worked better for me.

Also contains code in setup.sh to prevent a second entry in crontab.

you can customise the daemon filename as well.

setup.sh also downloads and installs freegeoip itself.

also the version I have I haven't had any issues with choking on ipv6 ips.

https://github.com/Foggyx420/Netdata-Test/blob/

use what u want.

[grctest]

@Foggyx420 I'm going to merge this in, I'd massively appreciate a pull request from your fork too 👍

@nethershaw Apologies for the late merge, thanks for your hard work!