search

grd349 / PBjam

A repo for our peak baggin code and tips on jam
MIT License
17 stars 6 forks source link

Add travis CI #111

Closed grd349 closed 4 years ago

grd349 commented 5 years ago

@ojhall94 @nielsenmb Shall we add travis CI to the repo? We are now public so this should be easy to do.

ojhall94 commented 5 years ago

We should for sure! Do we trust our unit tests?

nielsenmb commented 5 years ago

I'd say we should, I'd also like to find one that does documentation coverage checking.

On Thu, 18 Jul 2019 at 10:47, Oliver Hall notifications@github.com wrote:

We should for sure! Do we trust our unit tests?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/grd349/PBjam/issues/111?email_source=notifications&email_token=AEJWO35UDS6JCBEWDPA7VH3QAA3Z5A5CNFSM4IEYPWA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2H6E7A#issuecomment-512746108, or mute the thread https://github.com/notifications/unsubscribe-auth/AEJWO3YVAOFENRVI2XMZNRTQAA3Z5ANCNFSM4IEYPWAQ .

grd349 commented 5 years ago

We need more tests for sure - and we need more comprehensive and perhaps slow tests but we need more tests.

I have been playing with the @pytest.mark.slow decorator as suggested by @drstevenhale. We could probably make use of this to build some end-to-end tests where we check the output mode frequencies.

And yes @nielsenmb - checking doc coverage would be an idea. We can also do this as part of the code review though.

ojhall94 commented 5 years ago

Yeah great suggestion, I agree!

nielsenmb commented 4 years ago

Example travis CI configuration file. https://github.com/hannorein/rebound/blob/master/.travis.yml

Looks like you can do something with ipynb files too...

grd349 commented 4 years ago

Yes - neat.

I think the import bit is this step ...

python ipynb2py.py AdvWHFast.ipynb

Defo worth looking into!

G Dr Guy R. Davies PI - ERC CartographY Project Senior Lecturer in Astrophysics School of Physics and Astronomy The University of Birmingham Edgbaston Birmingham B15 2TT

Tel +44 (0) 121 414 4597 G.R.Davies@bham.ac.uk grd349@gmail.com davies@bison.ph.bham.ac.u davies@bison.ph.bham.ac.ukk davies@bison.ph.bham.ac.uk

The contents of this e-mail may be privileged and are confidential. It may not be disclosed, used, or copied in any way by anyone other than the addressee. If received in error please notify the sender then delete it from your system. Should you communicate with the sender by e-mail, you consent to The University of Birmingham monitoring and reading any such correspondence.

On Thu, 28 Nov 2019 at 14:46, Martin Nielsen notifications@github.com wrote:

Example travis CI configuration file. https://github.com/hannorein/rebound/blob/master/.travis.yml

Looks like you can do something with ipynb files too...

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/grd349/PBjam/issues/111?email_source=notifications&email_token=ADQZOCKXSRRPO7TYR76X43TQV7KVFA5CNFSM4IEYPWA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFMZX2Q#issuecomment-559520746, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQZOCOHN52CFOWK44FXOU3QV7KVFANCNFSM4IEYPWAQ .

nielsenmb commented 4 years ago

Travis CI seems to be working now.