search

grd349 / PBjam

A repo for our peak baggin code and tips on jam
MIT License
17 stars 6 forks source link

Fixed change of periodogram to pg in session and other minor change. #166

Closed alexlyttle closed 5 years ago

alexlyttle commented 5 years ago

Session would not initialise because peridogram had been changed to pg in the star.__init__() but not when star() is called in session. This is now fixed.

os.mkdir() changed to os.makedirs() in star.make_output_dir() because the latter allows the creation of sub-directories (without, it wouldn't let me store the star output in a new directory within the current working directory) - not a bug, but allows for more general use cases.

grd349 commented 5 years ago

Excellent - thanks Alex! This will be second nature anytime soon. I have assigned @nielsenmb for review because this is in star which is really his beautiful handy work!

nielsenmb commented 5 years ago

Alex and I already discussed this offline.

A minor change to be made is perhaps run make_output_dir already in the init. At the moment it's just done in star.call().

@alexlyttle disregard what I said earlier about putting it in session.py, that doesn't make sense. Calling the make_output_dir function should remain with the star class. Although defining such helper functions elsewhere might be a way to tidy up the code (perhaps in a jar somewhere?).