grd349 / PBjam

A repo for our peak baggin code and tips on jam
MIT License
17 stars 6 forks source link

Added l=1 detection #179

Closed nielsenmb closed 5 years ago

nielsenmb commented 5 years ago

Added a new module for detecting l=1 modes in 'simple' stars.

UNTESTED

It works on KIC8006161 (MS) and KIC4448777 (RG), but haven't tried it on other stars.

So I haven't written anything into star.call() and it's very much use at own risk at the moment.

Basically performs a H0 test on several levels of binning and then finds those that cluster together. The cluster between an l=0 and subsequent l=2 (of the same radial order), that has the highest number of samples is assumed to be the l=1 mode.

In the case of RGs this probably going to be the most p-mode-like mode (they tend to be broader I presume).

Will warn if a measured frequency is far away from the expected Universal Pattern for l=1 modes.

grd349 commented 5 years ago

Excellent work @nielsenmb

I'll put some time aside to run some tests. We should add some unit tests too - in fact we should add unit tests all over the place.