search

grd349 / PBjam

A repo for our peak baggin code and tips on jam
MIT License
17 stars 6 forks source link

Adding references- PBjam is now 0.1% TeX #247

Closed nielsenmb closed 4 years ago

nielsenmb commented 4 years ago

You can now get a list of references from session or star using the reference() method.

sess = session('catname', ....)
sess.references()

The list is updated based on what modules are run. So the star reference list won't show CPnest if you only use EMCEE in asy_peakbag for example, or similarly won't show pymc3 if you don't use the peakbag module.

If new modules are added to PBjam, you can add the references by using the _addRef() method

star.references._addRef('JoeSmith2020')

References that are not Python related, e.g., Gaia Collaboration are also shown.

This should be added where relevant (I haven't really come up with a good system yet). The _addRef method does require access the star class instance though. It might be possible to come up with a better way, so functions/classes that don't really know about the star class instance (helper functions) can still add to the list.

If new references are added, add the relevant BibTeX block to pbjam/data/pbjam_references.bib, just like you would in a LaTeX doc.

grd349 commented 4 years ago

Neat! :)

nielsenmb commented 4 years ago

This is ready to merge by the way.

nielsenmb commented 4 years ago

Looks like there's still some workflow stuff going on. Did you switch something back on?

grd349 commented 4 years ago

Not me (not in master). Paging @lmcarboneau :)

lmcarboneau commented 4 years ago

Looks like there's still some workflow stuff going on. Did you switch something back on?

Not me (not in master). Paging @lmcarboneau :)

Sorry, I keep missing notifications in GitHub... I think it should clear up once it's merged? If you branched this before the switch to Travis then it's possible that's what's triggering the workflow. It's also possible that odd branches hanging around with the workflow implementation instead of the Travis CI are keeping workflows active on the repo as a whole. Maybe there's a setting somewhere for removing it - at the very least the PR is passing in Travis so it should to be safe to merge

nielsenmb commented 4 years ago

Never got around to merging this PR. It seemed to get stuck in some workflow thing?

It now also contains the updated prior/posterior width ratio statistic in the peabagsummary{tgt}.csv.

nielsenmb commented 4 years ago

I think this PR needs to be merged by force.

There still seems to be an issue with Workflow.

grd349 commented 4 years ago

Done

Dr Guy R. Davies PI - ERC CartographY Project Senior Lecturer in Astrophysics School of Physics and Astronomy The University of Birmingham Edgbaston Birmingham B15 2TT

Tel +44 (0) 121 414 4597 G.R.Davies@bham.ac.uk grd349@gmail.com davies@bison.ph.bham.ac.u davies@bison.ph.bham.ac.ukk davies@bison.ph.bham.ac.uk

The contents of this e-mail may be privileged and are confidential. It may not be disclosed, used, or copied in any way by anyone other than the addressee. If received in error please notify the sender then delete it from your system. Should you communicate with the sender by e-mail, you consent to The University of Birmingham monitoring and reading any such correspondence.

On Thu, 17 Sep 2020 at 14:06, Martin Nielsen notifications@github.com wrote:

I think this PR needs to be merged by force.

There still seems to be an issue with Workflow.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/grd349/PBjam/pull/247#issuecomment-694218617, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQZOCLLHUZZDWKDDIKBIBDSGICTXANCNFSM4PGYMY6A .