search

gre / webgltexture-loader

load & cache various kind of WebGLTexture with an extensible and loosely coupled system
11 stars 12 forks source link

Fix broken NativeModules.ExponentGLObjectManager #12

Closed davidcian closed 4 years ago

davidcian commented 4 years ago

Due to Expo shifting things around with their constant updates, ExponentGLObjectManager has been moved from NativeModules to NativeModulesProxy, thus breaking some functionality ( the deprecated DeprecatedExpoGLObjectTextureLoader but also and most importantly the ExpoCameraTextureLoader). With this fix, people trying to obtain a texture from their camera should be able to do so again.

fdagostino commented 4 years ago

@gre can you merge this PR?

fdagostino commented 4 years ago

@davidcian how can I set package.json to temporarily use your fork since webgltexture-loader-expo is not used directly by my project but by gl-react-expo?

davidcian commented 4 years ago

@fdagostino Unfortunately you cannot set the package.json to use my fork, since that would require it to be a package. However, you can clone this fork and manually replace the package in the node_modules folder, along with installing the @unimodules/core dependency. Hope this helps!

fdagostino commented 4 years ago

@davidcian thanks, worked fine!