search

gre / webgltexture-loader

load & cache various kind of WebGLTexture with an extensible and loosely coupled system
11 stars 12 forks source link

Expo 27: ExponentGLObjectManager.createObjectAsync is not available #3

Closed wcandillon closed 6 years ago

wcandillon commented 6 years ago

I just upgraded to expo 27 and I'm hitting the warning/error at https://github.com/gre/webgltexture-loader/blob/34eaa88df6c28b0cbde82af1f29ca6c2a15938f2/packages/webgltexture-loader-expo/src/ExponentGLObjectTextureLoader.js#L11

Was the NativeModule renamed or something?

wcandillon commented 6 years ago

😍 Let me know when a new version is available on npm, I'm excited :)

gre commented 6 years ago

it's available on npm.

$ yarn list gl-react* expo webgltexture-loader*
yarn list v1.3.2
warning Filtering by arguments is deprecated. Please use the pattern option instead.
├─ expo@27.0.1
├─ gl-react-expo@3.16.3
├─ gl-react@3.15.0
├─ webgltexture-loader-expo@0.10.0
├─ webgltexture-loader-ndarray@0.9.0
└─ webgltexture-loader@0.6.0
✨  Done in 0.61s.

camera

gre commented 6 years ago

the way to implement it has changed a bit:

wcandillon commented 6 years ago

It works great, thanks a lot 🙌🏻

On Tue, May 8, 2018 at 4:36 PM, Gaëtan Renaudeau notifications@github.com wrote:

the way to implement it has changed a bit:

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gre/webgltexture-loader/issues/3#issuecomment-387424369, or mute the thread https://github.com/notifications/unsubscribe-auth/AASr1uAbP2fiRBafF_8fTNibFuWS993-ks5twa1xgaJpZM4TkqHa .

wcandillon commented 6 years ago

@gre Do you have an example of loading an image (local or remote) with this new version? I'm getting a crash. I tried to debug the loader but unsuccessfully. canLoad returns true and then the app crash and as far I know, no other method in the load is called 🤔

Thank you for your support.

gre commented 6 years ago

mmh the cookbook seems to work fine: https://github.com/gre/gl-react/blob/master/examples/cookbook-rn-shared/examples/diamondcrop/index.js#L31

need to do

{{ uri }}

which i'm not sure if it's a regression or not (to not being able to directly pass the url)

wcandillon commented 6 years ago

Hi Gaëtan,

Thank you for your support. Thanks to your example I was able to pin down the regression: local images don't work anymore. Maybe it's a read access problem? I will take a look again at the loader.

Kind regards,

William

On Wed, May 9, 2018 at 10:37 AM, Gaëtan Renaudeau notifications@github.com wrote:

mmh the cookbook seems to work fine: https://github.com/gre/gl- react/blob/master/examples/cookbook-rn-shared/examples/ diamondcrop/index.js#L31

need to do

{{ uri }}

which i'm not sure if it's a regression or not (to not being able to directly pass the url)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gre/webgltexture-loader/issues/3#issuecomment-387665795, or mute the thread https://github.com/notifications/unsubscribe-auth/AASr1pbmXsqglJ5mEoNoXz55Vi5SGDO2ks5twqrVgaJpZM4TkqHa .

gre commented 6 years ago

oh weird, yeah i'm not sure i've actually tested local images

wcandillon commented 6 years ago

localFile() is called and seem to crash but I cannot debug it: https://github.com/gre/webgltexture-loader/blob/master/packages/webgltexture-loader-expo/src/ExpoModuleTextureLoader.js#L53 Any ideas on how I could debug this further? So far I've been adding console.log() call to the function but I'm getting strange results.

On Wed, May 9, 2018 at 11:38 AM, Gaëtan Renaudeau notifications@github.com wrote:

oh weird, yeah i'm not sure i've actually tested local images

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gre/webgltexture-loader/issues/3#issuecomment-387682828, or mute the thread https://github.com/notifications/unsubscribe-auth/AASr1hLGqr11RQftzAXxkvFP-yvZaUXCks5twrkjgaJpZM4TkqHa .

gre commented 6 years ago

found it https://github.com/gre/webgltexture-loader/commit/3954f920f07d819ce59ad02c1dc8bfa6c7ef77ea