GitHub commit comments no longer sync if not selecting raw source

[adamlui]

In #1111 I gave you the idea to allow GitHub sync from HTML URLs. However I tested this out recently (when I moved a script into a subdir) and noticed 2 things:

1. Comments no longer sync with version history
2. A manual sync was required to update on GF (the v2023.01.29 in screenshot)

(v2023.01.29.1+ syncs comments sucessfully because I turned off syncing then re-added the raw source instead)

[JasonBarnabe]

What URL are you trying to use?

[adamlui]

The URLs I used were copied from address bar when viewing a script on GitHub. So the logic for syncing comments should be modified to locate them correctly if URL is not raw one (also for syncing it should target changes to raw one instead)

Sent from Proton Mail mobile

-------- Original Message -------- On Jan 30, 2023, 4:32 PM, Jason Barnabe wrote:

What URL are you trying to use?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

[adamlui]

Actually for syncing, one of them did it automatically (I think), but the other didn't, leading me to believe it somehow detects changes to raw URLs faster (since when I use raw URL the sync always happens in a second)

Sent from Proton Mail mobile

-------- Original Message -------- On Jan 30, 2023, 4:32 PM, Jason Barnabe wrote:

What URL are you trying to use?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

[JasonBarnabe]

Commit comments are only pulled in when you are using webhooks. If you are using Manual or Automatic syncing, it's just downloading the URL you provide and doesn't know anything about what commit comments you used.

[adamlui]

@JasonBarnabe but that's only half the issue, the unresolved half is

A manual sync was required to update on GF (the v2023.01.29 in screenshot)