search

greasyfork-org / greasyfork

An online repository of user scripts.
https://greasyfork.org
GNU General Public License v3.0
1.43k stars 431 forks source link

Update auto-synced to GF triggers 'Re-install' not 'Update' button #1118

Closed adamlui closed 1 year ago

adamlui commented 1 year ago

Hi,

I made a minor change to the code for https://greasyfork.org/en/scripts/459849-duckduckgpt via https://github.com/adamlui/userscripts/blob/master/chatgpt/duckduckgpt/duckduckgpt.user.js and changed version from 2023.02.13 to 2023.02.13.1

GF auto-synced the code:

image

...but the button didn't change to "Update to 2023.02.13.1" instead it kept "Reinstall" as the label for some reason. Clicking the button does reveal it's an update though:

image

JasonBarnabe commented 1 year ago

The issue was in the version comparison script - it compared all the parts of the old version to the same-indexed parts of the new version. This did not take into account the case where the new version has additional parts. This should be fixed now. Thanks for reporting.