search

greasyfork-org / greasyfork

An online repository of user scripts.
https://greasyfork.org
GNU General Public License v3.0
1.41k stars 422 forks source link

DuckDuckGPT + BraveGPT + GoogleGPT no longer show on https://greasyfork.org/en/scripts/by-site/* #1279

Closed adamlui closed 2 weeks ago

adamlui commented 2 weeks ago

https://greasyfork.org/en/scripts/459849-duckduckgpt doesn't show on https://greasyfork.org/en/scripts/by-site/duckduckgo.com https://greasyfork.org/en/scripts/462440-bravegpt doesn't show on https://greasyfork.org/en/scripts/by-site/brave.com https://greasyfork.org/en/scripts/478597-googlegpt doesn't show on https://greasyfork.org/en/scripts/by-site/google.com

This started happening within the last hour or so, do you know why?

adamlui commented 2 weeks ago

How strange, they have re-appeared in the results

adamlui commented 2 weeks ago

GoogleGPT disappeared from all https://greasyfork.org/en/scripts/by-site/* again. I made a code update 14mins ago so the bug appears related to that

JasonBarnabe commented 2 weeks ago

It may have been caused by a restart on the DB I did a couple days ago. Sometimes this can cause the search function it to fail to correctly process script updates.

I've run a manual task that may fix it.

JasonBarnabe commented 2 weeks ago

It appears to still be happening. Any update gets removed from search results until the hourly reindex happens. Not sure why.

adamlui commented 2 weeks ago

It felt like it wasn't that bad before your manual task it took ~20mins (but maybe the timing of my updates were closer to re-index time).

Also, I observed on script page from mobile, the "Updated: Now" would wildly jump from 1st column to 2nd column every sec like it was constantly updating, never saw that happen before, is probably the cause (every sec it is counting as "new" update so constantly removes from search results)

Also if it stays unfixed, that is quite bad because I make multiple updates like every hour all day, so it unfairly penalizes active script authors who continuously improve experience for Greasy Fork users by hiding their scripts to potentially only show a couple mins every hour (and then outdated, inactive scripts get all the exposure, which diminishes the Greasy Fork UX)

JasonBarnabe commented 2 weeks ago

I agree it should be fixed, but

Also if it stays unfixed, that is quite bad because I make multiple updates like every hour all day

This is not a reasonable thing to be doing and doing so makes me think you're just trying to stay at the top of the updated script list, which is against Greasy Fork's rules.

adamlui commented 2 weeks ago

No, it is absolutely reasonable, just not common. For example:

image

Notice I have two crucial commits lined up for pushing that vastly improve my scripts' UI, but because of this unfair penalty, I am now waiting until re-index time, thus also deterring further improvements that benefit users since I will not be drafting any more commits (since it's hard to soft-queue more than 2 at a time) such that 'History' gives an accurate overview for users to inspect specific changes and roll back if needed vs. pushing it all at once which would trigger one sync thus destroying the benefit of History

adamlui commented 2 weeks ago

I could care less if you were to change your Last Updated to be hourly refreshed to prove your accusation is unfounded, but it is critical my updates which my supporters demand at high speed (and even pay me for)...

image image image

... are met thru no obstacle outside my control. We just clearly have differing standards on what comprises user satisfaction (since you called my means not common) as for me it is primarily speed, even my hectic GitHub commit activity reveals this

So if you someday fix this bug, then implement the no bumps until every hour, you will see, even without the bumps, my commits will stay fast and furious for this purpose of satisfying user experience I highly prioritize, therefore it is impossible I'm abusing some rule I haven't heard of, just satisfying user demand ASAP that got me where I am today

adamlui commented 2 weeks ago

There are actual abusers who make updates that change nothing but version number though (every few days to weeks), go after them, don't worry about some guy that is bringing heavy traffic to Greasy Fork with awesome updated userscripts and links to GF as the de facto site for AI goodness everywhere he posts, thus generate you more ad revenue because I want you to keep the site alive as long as possible so our goals are very much aligned, we are on the same team sir (also look at my user number, I was the first 1000 members I think, I am not some new teenage member pulling some latest scheme on some site they don't care about, I'm 40 and I love GF it loves me back, I don't abuse my lovers)

adamlui commented 2 weeks ago

Also if you inspect the actual author update frequency of the /for-site my scripts apply to, it's commonly every few days to months. Why would a Greasy Fork schemer need to multi-bump per hour to stay on top? That is where I'm already healthy by daily installs (I'm #2 and #3 for OpenAi for months I don't need bumping)

adamlui commented 2 weeks ago

Also I was serious about buying the site just lemme know when you tire of it

adamlui commented 2 weeks ago

That is where I'm already healthy by daily installs (I'm #2 and #3 for OpenAi for months I don't need bumping

Actually I lost my #3 spot due to this glitch, it kept makign it disappear such that a #4 script that didtn' get updated in nearly a month took the place of mine that was getting updated with new APIs and UI features to make AI more awesome to users that they remember to come back to GF for more AI goodies

JasonBarnabe commented 2 weeks ago

I was referring specifically to your claim of

multiple updates like every hour all day

but looking at your script history, this is not what you're doing.

But this not relevant to the issue at hand, so let's keep this issue on-topic.

adamlui commented 2 weeks ago

Ok, I am happy to know you have confirmed I am not an abuser and very eager for a fix to bring GF more revenue (since I will update GoogleGPT less frequently to avoid the awkward penalty, I had some epic changes planned that would wow new visitors into thinking highly of this site on first impression to have AI scripts of such caliber, AI is like the hottest thing, it is like throwing money away to not fix, I bring a lot of AI user traffic from external sources I have thousands of followers)

JasonBarnabe commented 2 weeks ago

This is supposed to be instantaneously updated with ts-sidekiq-delta but something broke with that.

Until I can find the problem, I've put in a workaround - it will reindex every five minutes, so that's the maximum amount of time after an update that a script will be missing from results.

JasonBarnabe commented 2 weeks ago

I believe this is fixed now with 61f9dc11b25e5c1d8a32ef1e7e370d29c707c459. The problem was that ts-sidekiq-delta uses a redis-based lock to avoid concurrent runs, and at some point this was set and not cleared (probably due to a server reboot), preventing further processing. I've cleared the lock and also created https://github.com/pat/ts-sidekiq-delta/pull/14 to add a TTL prevent the problem from reoccurring.