greasyfork-org / greasyfork

An online repository of user scripts.
https://greasyfork.org
GNU General Public License v3.0
1.47k stars 441 forks source link

@description is limited to 500 characters #156

Closed jesus2099 closed 10 years ago

jesus2099 commented 10 years ago

Hello, today I was unable to import a script :

The following scripts could not be imported: https://raw.githubusercontent.com/jesus2099/konami-command/master/mb_SUPER-MIND-CONTROL-II-X-TURBO.user.js - Description is too long (maximum is 500 characters).

I know my description is awfully long but at the same time, I would not really want to shorten it, rather the opposite with time…

JasonBarnabe commented 10 years ago

I suggest you shorten your description. You can include everything else you want to say in your additional info.

Description needs to be relatively short so that we can sensibly show it all in a script list. This is one of the longest ones on the site, and it's kind of pushing it already...

jesus2099 commented 10 years ago

Woops, seems that my comment was not posted :

My suggestion would be like :

A VARCHAR kind of column (instead of CHAR(500)) could come handy, imo.

If the description is too large, an overflow:hidden block tag could be used so that interested users could click a read more kind of link.

But still it’s only a suggestion… :)

JasonBarnabe commented 10 years ago

What if I made the site truncate descriptions larger than 500 chars rather than error? That way, the script can still be imported, I'm satisfied with the length of data, and when users install they can see the full description?

jesus2099 commented 10 years ago

Oh yes, truncate and issue a warning, why not ! I’ve also thought of : Truncate description to 499, append an ellipsis character and put the remaining text in the body of the script page. Do you like it ? :)

jixunmoe commented 10 years ago

I think ellipsis took 2 char space..? On 24 Jun 2014 11:37, "PATATE12" notifications@github.com wrote:

Oh yes, truncate and issue a warning, why not ! I’ve also thought of : Truncate description to 499, append an ellipsis character and put the remaining text in the body of the script page. Do you like it ? :)

— Reply to this email directly or view it on GitHub https://github.com/JasonBarnabe/greasyfork/issues/156#issuecomment-46955911 .

jesus2099 commented 10 years ago

It’s U+2026. I don’t know if the 500 limit is in terms of characters or bytes anyway. :)…

JasonBarnabe commented 10 years ago

The 500 character limit on description is still a hard validation fail when manually creating or updating a script. When syncing, the description will be truncated at 500 characters for displaying on Greasy Fork, but will retain the full description in the code.

Let me know if it works for you now.

jesus2099 commented 10 years ago

Thanks ! : ;)