search

greasyfork-org / greasyfork

An online repository of user scripts.
https://greasyfork.org
GNU General Public License v3.0
1.47k stars 441 forks source link

Add donation link based on @contributionURL #221

Closed JasonBarnabe closed 10 years ago

JasonBarnabe commented 10 years ago

If a script providers a @contributionURL, link to it from the feedback page. Also suggest a donation of @contributionAmount if set?

tobbexiv commented 10 years ago

They are not standardized GM functions, aren't they? So it might be good to have a look at OpenUserJs/OpenUserJs.org#285 so that not everyone implements it's own syntax for including own meta tags.

JasonBarnabe commented 10 years ago

It was introduced by Scriptish (https://github.com/scriptish/scriptish/wiki/Manual%3A-Metadata-Block#contributionurl-new-in-scriptish) and has been mentionned as something to support by Greasemonkey (https://github.com/greasemonkey/greasemonkey/issues/1944). 42 scripts posted on Greasy Fork already use @contributionURL.

Since it's already out there, and since it's a reasonable implementation, I don't see any reason not to use it.

jerone commented 10 years ago

I'm :+1: on adding this feature. Only wondering how @contributionURL & @contributionAmount meta data items are related to each other. Both items are coming originally from Firefox addon SDK, but no documentation is given.

For me @contributionURL is more a page that contains information about how to contribute coding-/testing-/documenting- wise. Like the CONTRIBUTING.md file support on Github.

On the other side there's @contributionAmount which is the amount of money someone can contribute to development of the userscript/addon. For Firefox this goes to a predefined page on Mozilla addons using only PayPal as the set contribution way, like https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/developers?src=api

JasonBarnabe commented 10 years ago

"Contribution" means money here. @contributionURL is where you can donate and @contributionAmount is the suggested donation.

What you describe for @contributionURL is probably more a job for @supportURL.

JasonBarnabe commented 10 years ago

The scripts that already have @contributionURL are all links to payment providers (PayPal and Alipay) or to personal pages that describe how to donate, like http://cletusc.github.io/Userscript--Twitch-Chat-Emotes/#donate .

JasonBarnabe commented 10 years ago

Done. Examples:

No contribution amount: https://greasyfork.org/scripts/2708-youtube-center/feedback With contribution amount: https://greasyfork.org/scripts/3296-koc-throne-room-organizer/feedback

cletusc commented 10 years ago

Seems my script isn't showing this--bug?

JasonBarnabe commented 10 years ago

Yeah it is...

https://greasyfork.org/scripts/2213-twitch-chat-emotes/feedback

"Thank CletusC by making a donation."

cletusc commented 10 years ago

Doh, sorry. Didn't see that it was only on the "feedback" tab.