greasyfork-org / greasyfork

An online repository of user scripts.
https://greasyfork.org
GNU General Public License v3.0
1.42k stars 427 forks source link

feature request; Add social media buttons on script page #297

Closed tiansh closed 9 years ago

tiansh commented 9 years ago

as what userscripts.org did

JasonBarnabe commented 9 years ago

What social media would you want?

I think I would host the images myself to prevent tracking by third parties. This also means it wouldn't include the "Like" or equivalent counts.

tobbexiv commented 9 years ago

I'd assume that tiansh wants the option to share scripts. one possible solution to keep the tracking to a minimum would be something like this: https://github.com/panzi/SocialSharePrivacy

The third party code is only included when the user enables it explicitly. => Tracking is only possible if the user himself enables it.

tiansh commented 9 years ago

I mean buttons for share scripts.

I'm not sure if it is possible to implemented this without tracking, since I know nothing about developing on Twitter or Facebook in some reason. And I also prefer not tracked by this website. 虽然反正这些网站我一个也打不开

JasonBarnabe commented 9 years ago

Done with https://github.com/panzi/SocialSharePrivacy

tophf commented 9 years ago

There should be a profile option to not display this block of butt-ons, am I missing something?

tobbexiv commented 9 years ago

Why should it be there? The buttons you see are only placeholders for the real social media buttons. Therefore you have to click on them to enable the specific social media include. The commit also has no modification to implement such a setting.

tophf commented 9 years ago

@tobias-engelmann, the profile setting must exist in order to remove the block of the social butt-ons entirely, obviously. And though I personally can hide it with an adblocker/stylish but my point is that GreasyFork receives more damage from the ugly looking social block than benefiting from an extremely rarely used sharing abilities (0.01% of GF scripts will be shared a few times). I fail to see the reason for unconditionally stuffing this dubious thing for everyone and everywhere, GF isn't a news site, but currently this block is even larger than the logotype and site name in the header. This is beyond subjectively ridiculous, this is objectively wrong. All sane sites show such buttons 4 times smaller, even the JB's sibling project userstyles.org.

sooobutt

This is shown for everyone, even those who haven't signed in.

JasonBarnabe commented 9 years ago

I'm not going to be adding prefs to turn site features on or off. If you think it's ugly, I welcome suggestions for improvement. If you don't like the core concept, you know how to get rid of it.

userstyles.org will actually probably get the same kind of buttons soon.

tophf commented 9 years ago

Well, it's your site, so if you really don't mind it getting closer to a typical horribly designed site from the 00s with lots of visually incompatible stuff, then it'd be only reasonable for me not to butt in and inflict my point of view any further.

JasonBarnabe commented 9 years ago

I had tried with the style of buttons userstyles.org has ("line"). The problem is that the same widget coming from the same provider can be different sizes depending on the number of likes/shares/gryzzyls the page has, the language, whether your friends like/share/gryzzyl it too. So you get unused spaces, uneven spacing, no alignment, etc. Also, since the widget is not activated until the user choses, it's impossible to get a good-sized placeholder, so you get things jumping around when the user turns stuff on. With the "box" widgets, the sizes are much more standardized.

If you have a suggestion for how to do this without having tracking on automatically, I'm willing to look into it, but the only I suggestion I've heard so far has been @tobias-engelmann's, and that's the one I used.

tophf commented 9 years ago

I see.

And the block should be displayed in its full state with settings and placeholders even for the users who aren't signed in?

I only ask because it seems like something went wrong, at least I never ever saw a social block with all that placeholders and whistles (see the screenshot) as a plain visitor, moreover typically it's 5-20 times smaller and only has the social buttons per se.

JasonBarnabe commented 9 years ago

The settings and placeholders are related to it not tracking you just by loading the page. Typically you are being tracked.

tophf commented 9 years ago

Typically those few percent of users concerned about tracking won't be tracked anyway because they use NoScript, Ghostery, ScriptSafe, uBlock, AdBlock and so on. On the other hand, the majority of visitors will see this absurdly humongous blob for no benefit. Where's the logic? There seems to be none.

JasonBarnabe commented 9 years ago

I think at this point, you're just trying to be right rather than trying to be helpful.

If anyone has suggestions on how to improve how this looks or works, please create a new issue with your suggestion. If you don't like the general concept, then you know what to do :)

tophf commented 9 years ago

To improve something the first thing to do is to acknowledge its shortcomings. If you, the site owner, would care, then, I guess, you'd either not use this wrecked library or would have reverted the change after seeing the result and postpone the issue until a better solution is suggested. But you've preferred to shift the discussion from the actual object to mocking the person who cares about the way the site looks. Well then why should I care?

tiansh commented 9 years ago

I think the large gray buttons (placeholders) are ugly. Maybe it could be hidden when disabled. Only leave a “share” button / menu there is enough. User can enable any buttons by one click and set it enabled by default. Store the status in user profile or cookies / localStorage. Also maybe some smaller buttons may look better than these ones.

JasonBarnabe commented 9 years ago

The placeholders reflect the size of the widgets so that when you activate them, things don't jump around. The sizes of widgets available are limited - see for example https://developers.facebook.com/docs/plugins/like-button. The "button" style does not have a standard width across providers or even in different situations with the same provider, which makes it really hard to lay out a bunch of them. Only the "box" style is more or less standard.

Possible alternatives I can think of:

tobbexiv commented 9 years ago

Maybe hide it and display it on a click on the "Share" caption? Then store the display state as a cookie.

So initially it is hidden and with a click on the caption it is possible to show hide it?

Edit: I found a second framework but it has less languages supported and also less supported sites: https://github.com/heiseonline/shariff