greasyfork-org / greasyfork

An online repository of user scripts.
https://greasyfork.org
GNU General Public License v3.0
1.49k stars 446 forks source link

Unordered lists aren't rendered correctly #537

Closed chocolateboy closed 6 years ago

chocolateboy commented 6 years ago

[moved from a comment in #535]

535 appears to have removed the indented bullets from unordered lists (on desktop) e.g.:

Before

Before

After

After

This change appears to have been caused by the addition of this rule:

#script-content ul {
    list-style-type: none;
    padding: 0;
}
JasonBarnabe commented 6 years ago

@strongop any particular reason that block of code was added?

ghost commented 6 years ago

history version list is pre-pend with that list style, which I think is not necessary. I think the default list style is old fashioned compared to other styles in the page, so I removed it. But the description markdown/html may need that to make contents easily distinguished. I think add explicit styles for description markdown/html might be a good choice.

ghost commented 6 years ago

or change the default black solid circle to something else.

chocolateboy commented 6 years ago

I don't agree that bulleted lists are "old fashioned", and from a quick survey neither do:

- or any other sites I could find lists on.

I also think that rejecting time-honored traditions on the grounds that they're "old fashioned" leads to design that not only doesn't work, but which can be actively harmful.

Note that the list in the Hawaii Missile Alert Test UI doesn't have bullets:

Missile Test UI

tobbexiv commented 6 years ago

I use Bullet lists for example for release notes. Each bullet presents one feature which was added or a bug that was fixed. I chose a bullet list for better readability, but now this list is not readable at all. Also the derivative list is now hard to read.

Additionally this also broke the script discussion list: https://greasyfork.org/de/scripts/4369-ikariam-enhanced-ui/feedback

So I would highly appreciate to change it back as using a list should be choice of the script author and not the page itself.

JasonBarnabe commented 6 years ago

I have restored the bullets.

ghost commented 6 years ago

save https://assets-cdn.github.com/assets/github-9a96827cb922.css from firefox style editor.

$ cat github-9a96827cb922.css | grep -E 'list-style[^:;]:\s[^:;]' | grep none |wc -l 66

$ cat github-9a96827cb922.css | grep -E 'list-style[^:;]:\s[^:;]' | grep -v none |wc -l 2

chocolateboy commented 6 years ago

Yes, there are a few exceptions (there's no need to explicitly state and repeat base/default styles) on GitHub and other sites, but the project's own changelog uses indented bullets like every other site that places a premium on conveying information rather than blindly following trends.

P.S.

// Did someone complain about list spacing? Encourage them // to create the spacing with their markdown formatting. // List behavior should be controled by the markup, not the css.

JasonBarnabe commented 6 years ago

I think with user-provided text, we should do the expected thing and have the default bullets.

Outside of user-provided text, the initial change broke a few things, but I'm not set on having bullets anywhere they are currently.