great-expectations / great_expectations

Always know what to expect from your data.
https://docs.greatexpectations.io/
Apache License 2.0
9.63k stars 1.49k forks source link

[MAINTENANCE] Add new warning to ignore for pandas sql. #10070

Closed billdirks closed 2 days ago

billdirks commented 2 days ago

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

netlify[bot] commented 2 days ago

Deploy Preview for niobium-lead-7998 canceled.

Name Link
Latest commit 8019bbff1f8342ebbaf4a734f1a1d906a3d86cf0
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/667f2b31a523120008854952
codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.55%. Comparing base (40eb30f) to head (8019bbf).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #10070 +/- ## ======================================== Coverage 79.55% 79.55% ======================================== Files 456 456 Lines 39410 39410 ======================================== Hits 31354 31354 Misses 8056 8056 ``` | [Flag](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | Coverage Δ | | |---|---|---| | [3.10](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `66.05% <ø> (ø)` | | | [3.10 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `45.85% <ø> (ø)` | | | [3.10 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.64% <ø> (ø)` | | | [3.10 databricks](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `46.99% <ø> (ø)` | | | [3.10 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `60.43% <ø> (ø)` | | | [3.10 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `49.99% <ø> (ø)` | | | [3.10 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `50.05% <ø> (ø)` | | | [3.10 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.20% <ø> (ø)` | | | [3.10 snowflake](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 spark](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `57.42% <ø> (ø)` | | | [3.10 trino](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `52.11% <ø> (ø)` | | | [3.11](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `66.05% <ø> (ø)` | | | [3.11 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `45.85% <ø> (ø)` | | | [3.11 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.64% <ø> (ø)` | | | [3.11 databricks](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `46.99% <ø> (ø)` | | | [3.11 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `60.43% <ø> (ø)` | | | [3.11 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `49.99% <ø> (ø)` | | | [3.11 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `50.05% <ø> (ø)` | | | [3.11 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.20% <ø> (ø)` | | | [3.11 snowflake](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `47.77% <ø> (ø)` | | | [3.11 spark](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `57.42% <ø> (ø)` | | | [3.11 trino](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.12](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `64.62% <ø> (ø)` | | | [3.12 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `45.85% <ø> (ø)` | | | [3.12 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.63% <ø> (ø)` | | | [3.12 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `60.43% <ø> (ø)` | | | [3.12 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `49.99% <ø> (ø)` | | | [3.12 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `50.05% <ø> (ø)` | | | [3.12 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.20% <ø> (ø)` | | | [3.12 spark](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `57.42% <ø> (ø)` | | | [3.12 trino](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `52.12% <ø> (ø)` | | | [3.8](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `66.10% <ø> (-0.01%)` | :arrow_down: | | [3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.60% <ø> (ø)` | | | [3.8 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `45.88% <ø> (ø)` | | | [3.8 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.66% <ø> (ø)` | | | [3.8 databricks](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `47.02% <ø> (ø)` | | | [3.8 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `60.45% <ø> (ø)` | | | [3.8 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `49.98% <ø> (ø)` | | | [3.8 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `50.04% <ø> (ø)` | | | [3.8 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.19% <ø> (ø)` | | | [3.8 snowflake](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `47.79% <ø> (ø)` | | | [3.8 spark](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `57.39% <ø> (ø)` | | | [3.8 trino](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `52.11% <ø> (ø)` | | | [3.9](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `66.10% <ø> (+<0.01%)` | :arrow_up: | | [3.9 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `45.87% <ø> (ø)` | | | [3.9 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.65% <ø> (ø)` | | | [3.9 databricks](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `47.01% <ø> (ø)` | | | [3.9 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `60.44% <ø> (ø)` | | | [3.9 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `49.97% <ø> (ø)` | | | [3.9 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `50.03% <ø> (ø)` | | | [3.9 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.18% <ø> (ø)` | | | [3.9 snowflake](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `47.79% <ø> (ø)` | | | [3.9 spark](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `57.39% <ø> (ø)` | | | [3.9 trino](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `52.10% <ø> (ø)` | | | [cloud](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `0.00% <ø> (ø)` | | | [docs-basic](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `48.86% <ø> (ø)` | | | [docs-creds-needed](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `49.99% <ø> (ø)` | | | [docs-spark](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10070/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `48.72% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

billdirks commented 2 days ago

We already try to ignore this warning here: https://github.com/great-expectations/great_expectations/blob/develop/pyproject.toml#L567