search

great-expectations / great_expectations

Always know what to expect from your data.
https://docs.greatexpectations.io/
Apache License 2.0
10k stars 1.55k forks source link

[MAINTENANCE] Refactor Checkpoint utils #10649

Closed cdkini closed 1 week ago

cdkini commented 1 week ago

These should be coupled with actions - no need for a utils file

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

netlify[bot] commented 1 week ago

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit e84c39dd157fb1d13bcfa7840c2b69c7a908464a
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/672e90fbca24bf0008a8e311
Deploy Preview https://deploy-preview-10649.docs.greatexpectations.io
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 67.50000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 80.43%. Comparing base (7d650d9) to head (e84c39d). Report is 3 commits behind head on develop.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
great_expectations/checkpoint/actions.py 67.50% 26 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #10649 +/- ## =========================================== + Coverage 80.37% 80.43% +0.06% =========================================== Files 463 462 -1 Lines 40113 40098 -15 =========================================== + Hits 32240 32254 +14 + Misses 7873 7844 -29 ``` | [Flag](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | Coverage Ξ” | | |---|---|---| | [3.10](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `68.14% <67.50%> (+0.06%)` | :arrow_up: | | [3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 clickhouse](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 spark_connect](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 trino](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `68.13% <67.50%> (+0.04%)` | :arrow_up: | | [3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 clickhouse](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 spark_connect](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 trino](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.12](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `68.14% <67.50%> (+0.06%)` | :arrow_up: | | [3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `55.40% <17.50%> (-0.02%)` | :arrow_down: | | [3.12 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `46.15% <17.50%> (-0.01%)` | :arrow_down: | | [3.12 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.75% <17.50%> (+<0.01%)` | :arrow_up: | | [3.12 databricks](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `47.88% <17.50%> (-0.01%)` | :arrow_down: | | [3.12 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `61.71% <33.75%> (-0.01%)` | :arrow_down: | | [3.12 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `51.49% <17.50%> (-0.01%)` | :arrow_down: | | [3.12 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `51.56% <17.50%> (-0.01%)` | :arrow_down: | | [3.12 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.63% <17.50%> (+<0.01%)` | :arrow_up: | | [3.12 snowflake](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `48.86% <17.50%> (-0.01%)` | :arrow_down: | | [3.12 spark](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `58.07% <17.50%> (+<0.01%)` | :arrow_up: | | [3.12 spark_connect](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `46.44% <17.50%> (-0.01%)` | :arrow_down: | | [3.12 trino](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `52.68% <17.50%> (-0.01%)` | :arrow_down: | | [3.9](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `68.18% <67.50%> (+0.06%)` | :arrow_up: | | [3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `55.40% <17.50%> (-0.02%)` | :arrow_down: | | [3.9 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `46.17% <17.50%> (-0.01%)` | :arrow_down: | | [3.9 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.76% <17.50%> (+<0.01%)` | :arrow_up: | | [3.9 clickhouse](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `43.03% <17.50%> (-0.01%)` | :arrow_down: | | [3.9 databricks](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `47.90% <17.50%> (-0.01%)` | :arrow_down: | | [3.9 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `61.73% <33.75%> (-0.01%)` | :arrow_down: | | [3.9 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `51.48% <17.50%> (-0.01%)` | :arrow_down: | | [3.9 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `51.54% <17.50%> (-0.01%)` | :arrow_down: | | [3.9 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.62% <17.50%> (+<0.01%)` | :arrow_up: | | [3.9 snowflake](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `48.87% <17.50%> (-0.01%)` | :arrow_down: | | [3.9 spark](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `58.03% <17.50%> (+<0.01%)` | :arrow_up: | | [3.9 spark_connect](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `46.45% <17.50%> (-0.01%)` | :arrow_down: | | [3.9 trino](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `52.67% <17.50%> (-0.01%)` | :arrow_down: | | [cloud](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `0.00% <0.00%> (ΓΈ)` | | | [docs-basic](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `53.36% <17.50%> (+<0.01%)` | :arrow_up: | | [docs-creds-needed](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `52.93% <17.50%> (-0.01%)` | :arrow_down: | | [docs-spark](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `52.41% <17.50%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.